Skip to content

fix: use changeDetectorRef.detectChanges() instead of detectChanges() private api#99

Merged
edusperoni merged 1 commit intomainfrom
fix/detect-changes-modals
Nov 23, 2022
Merged

fix: use changeDetectorRef.detectChanges() instead of detectChanges() private api#99
edusperoni merged 1 commit intomainfrom
fix/detect-changes-modals

Conversation

@edusperoni
Copy link
Copy Markdown
Collaborator

PR Checklist

What is the current behavior?

Turns out that the detectChanges doesn't actually detect changes (or maybe rather doesn't mark the component for change detection)

What is the new behavior?

We force the change detection via changeDetectorRef.detectChanges(), which solves a few issues with CD being run AFTER the view is created and attached

@cla-bot cla-bot bot added the cla: yes label Nov 23, 2022
@edusperoni edusperoni merged commit 4e33561 into main Nov 23, 2022
@edusperoni edusperoni deleted the fix/detect-changes-modals branch November 23, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant